Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Parameter with new types - #109

Merged
marcserrat merged 5 commits into
masterfrom
LITE-13315-changes-to-support-different-parameter-types
Jun 26, 2020
Merged

Parameter with new types#109
marcserrat merged 5 commits into
masterfrom
LITE-13315-changes-to-support-different-parameter-types

Conversation

@martinconstante

Copy link
Copy Markdown
Collaborator

LITE-13675 Deprecate _in filters
LITE-13315 Parameter with new types
TCR template ID optional

LITE-13315 Parameter with new types
TCR template ID optional
@martinconstante
martinconstante requested review from a user and marcserrat June 23, 2020 15:07
Comment thread examples/config.json Outdated
Comment thread connect/models/schemas.py Outdated
Comment thread connect/resources/product.py Outdated
Comment thread tests/test_product.py Outdated
Comment thread examples/manage_asset_request.py Outdated
Comment thread connect/models/constraints.py Outdated
Comment thread connect/models/param.py Outdated
Comment thread connect/models/schemas.py
@marcserrat
marcserrat requested review from a user, d3rky and vgrebenschikov June 25, 2020 16:38
"""
if not product_id:
raise ValueError('Invalid ID')
path = '/public/v1/products/' + product_id + '/parameters/' + parameter_id

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to use urljoin

@marcserrat
marcserrat merged commit a75d7c1 into master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants