CPS-82 - Fix to update_parameters - #112
Merged
marcserrat merged 1 commit intoJul 14, 2020
Merged
Conversation
ghost
approved these changes
Jul 10, 2020
d3rky
approved these changes
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of
update_parametersinFulfillmentAutomationandTierConfigAutomationwas not parsing parameters that contain subobjects correctly, due to the fact that the__dict__dunder used to convert the param to a dict is not recursive. Code has been updated to use thejsonproperty that models have in the SDK, that return the model with the same representation that is returned when parsed with thejson.loadsfunction.