Added Stream to UploadAsync #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c46c4a to
e315650
Compare
Contributor
Author
|
Should I remove the integration test for stream? It seems like having 3 target frameworks and 2 separate tests for byte-array and stream is too much (6 API requests in total). The unit test fails with: {"message":"You have started too many jobs at once","code":"PARALLEL_JOB_LIMIT_EXCEEDED"} |
Contributor
|
I just cleaned up that queue and tests went through now. Looks great, thanks a lot! Could you also update the README here to use a stream instead of a byte array? (including |
Contributor
Author
|
Done. The preview can be viewed at https://github.com/GerardSmit/cloudconvert-dotnet/tree/feature/upload-stream#uploading-files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following method to
ICloudConvertAPI:Currently it's only possible to send a byte-array. Because of this, you have to load the file into memory before sending it to CloudConvert. This is fine for small files but loading large files could be a memory problem.
It's noteworthy that the stream doesn't get disposed by the API, so for example:
In this example the
streamis still open. You'll have toDisposethe stream yourself (or useusing var stream = ...).Tests
I've added an internal constructor in
RestHelperand made the internals visible to the Tests-project. This is so I can mock the HTTP-client and check if the stream doesn't get disposed byCloudConvertAPI.