Implement missing MQTTv3 protocol support #1190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a023b80 to
bfb8960
Compare
Signed-off-by: Dariusz Górecki <[email protected]>
Signed-off-by: Dariusz Górecki <[email protected]>
Signed-off-by: Dariusz Górecki <[email protected]>
bfb8960 to
dd2df6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to docs MQTTv3 should be supported, but the Go SDK lacks v3 support.
Probably thats's because paho has 2 confusingly named libraries:
github.com/eclipse/paho.golang- used currently by the SDK, it only supports MQTT v5github.com/eclipse/paho.mqtt.golang- older client that supports MQTT v3This PR implements proto that would support v3 servers, tested with mochi broker.
Any feedback welccome!