Thanks to visit codestin.com
Credit goes to github.com

Skip to content

nix dependency version update - #817

Closed
antoncxx wants to merge 3 commits into
cloudflare:mainfrom
antoncxx:freebsd_build_fix
Closed

nix dependency version update#817
antoncxx wants to merge 3 commits into
cloudflare:mainfrom
antoncxx:freebsd_build_fix

Conversation

@antoncxx

Copy link
Copy Markdown
Contributor

Fixes #814

While testing, I noticed that simply bumping the dependency version worked on my FreeBSD system without any immediate issues. However, I later discovered that the latest nix release introduces breaking API changes compared to version 0.24.x.

This PR updates the code to use the latest nix APIs to ensure compatibility with the current version.

Please take a look and let me know if any additional changes are needed.

Thank you!

@johnhurt johnhurt added the dependencies Pull requests that update a dependency file label Mar 13, 2026
@drcaramelsyrup drcaramelsyrup added the Accepted This change is accepted by us and merged to our internal repo label May 29, 2026
drcaramelsyrup pushed a commit that referenced this pull request Jun 3, 2026
Fixed formatting

Fixed clippy errors

Includes-commit: 72c03b3
Includes-commit: 92d8050
Includes-commit: b3de911
Replicated-from: #817
@drcaramelsyrup

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! we've accepted this in 7e29246.

@antoncxx
antoncxx deleted the freebsd_build_fix branch June 26, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted This change is accepted by us and merged to our internal repo dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pingora-core fails to compile on FreeBSD

4 participants