patch piphack script versions of pip 19.1+ #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryYC
approved these changes
Feb 18, 2021
abakhru
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
pip>20 and above has 'new resolver' which could cause troubles (https://pip.pypa.io/en/stable/news/), need to test it throughly.
zdelagrange
approved these changes
Feb 18, 2021
|
1 nit from me. without knowing enough about pip. the code looks sane. |
yeah, agree, lots of testing needed for pip upgrade and not proposing we go ahead w/ that after this PR. it's just that some boxes come w/ pip 20 installed which was breaking the script in this cookbook since all the internal apis changed which was preventing pip from being downgraded to 18. |
iashwash
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also removed a blurb that wasn't doing anything in
python_runtime_pip.rbtested on pip versions 20+ as well as 19 and 18. should still be careful reviewing this and testing though.