[o11y] Fix use-after-move with kv spans #5079
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't move the trace context to the attachWithSpans call and within the underlying KV call. Instead, only pass a reference for promise continuations within the KV calls. This may have resulted in incorrect span lifetimes or missing span tags.
|
Well, that doesn't actually work. I think something with the design of attachSpans() is causing trouble here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't move the trace context to the attachWithSpans call and within the underlying KV call. Instead, only pass a reference for promise continuations within the KV calls.
This may have resulted in incorrect span lifetimes or missing span tags.