Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix re-deploying after container deploys fail in an incomplete state #10253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2025
Merged

fix re-deploying after container deploys fail in an incomplete state #10253

merged 5 commits into from
Aug 13, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Aug 6, 2025 •
edited
Loading

Fixes CC-5809

This covers two cases:

  1. container app deployment is rejected by the coordinator api. an image has been pushed, but no app created. therefore the next time we deploy, we find the image exists already, think we can just use the previous app's image uri, but there is no prev app. this PR changes it to use the remote digest that we get from inspecting the remote manifest.
  2. worker is deleted, which deletes the DO and container but not the image. if we try and redeploy with the same name, the image still exists so we hit the same problem as above. this should really be fixed on the api side (atomic deletions), but at least this unbreaks that for now.
  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: new

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 25cd368

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Aug 6, 2025
@emily-shen emily-shen changed the title use remote digest sha if no prev deployment is found fix re-deploying after container deploys fail in an incomplete state Aug 6, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 6, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10253

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10253

miniflare

npm i https://pkg.pr.new/miniflare@10253

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10253

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10253

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10253

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10253

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10253

wrangler

npm i https://pkg.pr.new/wrangler@10253

commit: c6090b4

@emily-shen emily-shen force-pushed the emily/fix-half-broken-deploys branch from 7553724 to 57f01be Compare August 8, 2025 12:27
@emily-shen emily-shen marked this pull request as ready for review August 8, 2025 12:27
@emily-shen emily-shen requested review from a team as code owners August 8, 2025 12:27
@github-actions GitHub Actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/fix-half-broken-deploys might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10253
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@petebacondarwin
Copy link
Contributor

Conflicts ... 😢

petebacondarwin
petebacondarwin reviewed Aug 11, 2025
View reviewed changes
@emily-shen emily-shen force-pushed the emily/fix-half-broken-deploys branch from a725a62 to ecc4aa6 Compare August 11, 2025 13:23
nikitassharma
nikitassharma approved these changes Aug 11, 2025
View reviewed changes
@emily-shen emily-shen force-pushed the emily/fix-half-broken-deploys branch from ecc4aa6 to a1ea81d Compare August 11, 2025 15:02
@emily-shen emily-shen force-pushed the emily/fix-half-broken-deploys branch from 9a94971 to 25cd368 Compare August 11, 2025 16:04
@emily-shen emily-shen added the skip-v3-pr Skip validation of presence of a v3 backport PR label Aug 12, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 13, 2025
@emily-shen emily-shen merged commit eb32a3a into main Aug 13, 2025
39 of 40 checks passed
@emily-shen emily-shen deleted the emily/fix-half-broken-deploys branch August 13, 2025 12:47
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 13, 2025
@workers-devprod workers-devprod mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@nikitassharma nikitassharma nikitassharma approved these changes

Assignees
No one assigned
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emily-shen @petebacondarwin @nikitassharma