Thanks to visit codestin.com
Credit goes to github.com

Skip to content

skip flaky browser render test on Windows #10311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

skip flaky browser render test on Windows #10311

merged 1 commit into from
Aug 11, 2025

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Aug 11, 2025 •
edited
Loading

This test is constantly flaking on Windows, so we will skip it for now.
@ruifigueira - can you look into re-enabling this as part of your other work on Browser rendering?

@petebacondarwin petebacondarwin requested a review from a team as a code owner August 11, 2025 08:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2025

⚠️ No Changeset found

Latest commit: d817a35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Aug 11, 2025
@petebacondarwin petebacondarwin added skip-pr-description-validation Skip validation of the required PR description format no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR labels Aug 11, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 11, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10311

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10311

miniflare

npm i https://pkg.pr.new/miniflare@10311

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10311

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10311

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10311

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10311

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10311

wrangler

npm i https://pkg.pr.new/wrangler@10311

commit: d817a35

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 11, 2025
@ruifigueira
Copy link
Contributor

ruifigueira commented Aug 11, 2025 •
edited
Loading

Sure. I'm trying to make browser rendering chrome installation more reliable in #10306.

@petebacondarwin petebacondarwin merged commit a63b379 into main Aug 11, 2025
54 of 60 checks passed
@petebacondarwin petebacondarwin deleted the pbd/miniflare/browser-render-skip branch August 11, 2025 11:07
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

Assignees
No one assigned
Labels
no-changeset-required skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petebacondarwin @ruifigueira @CarmenPopoviciu