Thanks to visit codestin.com
Credit goes to github.com

Skip to content

V3 backport of #10288 #10330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

V3 backport of #10288 #10330

merged 1 commit into from
Aug 14, 2025
+15 −74

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Aug 12, 2025 •
edited
Loading

Backports #10288 to V3

@tgarg-cf @petebacondarwin
fix(wrangler) remove putQueue call when deploying a worker with queue…
68fac8a 
… producer binding (#10288)

* MQ-861: Remove putQueue call when setting queue producer binding

* remove calls to mockPutQueueById in tests

* Update .changeset/chatty-pens-sniff.md

Co-authored-by: Pete Bacon Darwin <[email protected]>

* try to ensure that the required deploy workers job is not skipped

* test: add a waitFor around log check for email bindings

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>
Co-authored-by: Peter Bacon Darwin <[email protected]>
@petebacondarwin petebacondarwin added the skip-pr-description-validation Skip validation of the required PR description format label Aug 12, 2025
@petebacondarwin petebacondarwin requested a review from a team as a code owner August 12, 2025 09:12
@petebacondarwin petebacondarwin requested a review from a team August 12, 2025 09:12
@petebacondarwin petebacondarwin requested review from a team as code owners August 12, 2025 09:12
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2025

🦋 Changeset detected

Latest commit: 68fac8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin mentioned this pull request Aug 12, 2025
Merged
6 tasks
@petebacondarwin petebacondarwin changed the base branch from main to v3-maintenance August 12, 2025 13:02
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Aug 12, 2025
@petebacondarwin petebacondarwin added the v3-backport The PR is a v3 backport targetting the v3-maintenance branch label Aug 13, 2025
CarmenPopoviciu
CarmenPopoviciu approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to action on those codeQL warnings?

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 14, 2025
@petebacondarwin petebacondarwin merged commit dab7683 into v3-maintenance Aug 14, 2025
27 of 32 checks passed
@petebacondarwin petebacondarwin deleted the v3-backport-10288 branch August 14, 2025 15:45
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 14, 2025
@workers-devprod workers-devprod mentioned this pull request Aug 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

Assignees
No one assigned
Labels
skip-pr-description-validation Skip validation of the required PR description format v3-backport The PR is a v3 backport targetting the v3-maintenance branch
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petebacondarwin @CarmenPopoviciu @tgarg-cf