Wrangler preview urls default to disabled #10478
Conversation
🦋 Changeset detectedLatest commit: 2ebea4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
b7c907a to
eff365d
Compare
Hey @danielrs thanks for the PR. Could you expand on the rationale of this change? |
|
@vicb We think that this feature is better off disabled by default, users can explicitly opt-in depending on their use-case. |
eff365d to
8f30d41
Compare
8f30d41 to
9982203
Compare
Should make the logic easier to understand.
We want preview_urls to be opt-in, rather than opt-out. For this reason its default value will be falsy.
Some of the previous commits that changed defaulting uncovered that most Wrangler Wrangler tests that had at least one route, were not mocking the appropriate calls to zones and routes endpoints.
9982203 to
ffb1170
Compare
Wrangler differs from the Dash and other clients in that it makes a lot decisions for the user regarding the status of the Worker subdomain. The header should help with existing and future breaking changes between Wrangler and the API.
Warn the user when the workers.dev or preview URLs status does not match their Wrangler config file.
ffb1170 to
2ebea4c
Compare
|
we went over these changes together and they look good in conjunction with the API changes ✅ |
|
Congratulations @danielrs, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmf4anyqt0001ju04kwvrfaiw This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
|
👋 Just filed #10722 for this, but with this change, wrangler is now forcibly disabling preview URLs even if you enable them in the dashboard, if you call |
Describe your change...
This change makes preview_urls disabled by default when it's not provided, making
the feature opt-in instead of opt-out.
Internal tracking: https://jira.cfdata.org/browse/RM-24647