Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor remote config related code #10519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 2, 2025
Merged

Refactor remote config related code #10519

merged 12 commits into from
Sep 2, 2025

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Sep 1, 2025 •
edited
Loading

Fixes #10361

This PR does a bit of refactoring, comprised of:

  • moving shared logic in the more appropriate wrangler utils directory
  • reorder some functions args in a more clear manner
  • adding some tsdocs comments
  • better renaming some functions

These changes are split pretty cleanly across the PR's commits

  • Tests
    • Tests included
    • Tests not necessary because: This logic is already tested (some more focused unit tests could be added but that's not the scope of this PR)
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Internal refactoring without any user facing changes
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: The refactoring in this PR is related to Better Wrangler config diff #10235 and containers, both features not in the v3 branch, moreover (I did attempt to backport the changes less related to these features) it seems like the relevant code in the v3 branch is significantly diverged from that of main, making the backporting here quite complex, providing an additional reason as to why this probably should not be backported. (If someone strongly believe that we should indeed try to backport these changes I am fully open to the idea, but again, to me it sounds both unnecessary and cosly)

@dario-piotrowicz dario-piotrowicz requested review from a team as code owners September 1, 2025 15:37
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: cd2c310

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 1, 2025
@dario-piotrowicz dario-piotrowicz changed the title Refactor remote config related logic Refactor remote config related code Sep 1, 2025
edmundhung
edmundhung approved these changes Sep 2, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 2, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 2, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10519

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10519

miniflare

npm i https://pkg.pr.new/miniflare@10519

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10519

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10519

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10519

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10519

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10519

wrangler

npm i https://pkg.pr.new/wrangler@10519

commit: cd2c310

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/10361/move-diff-logic might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10519
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@dario-piotrowicz dario-piotrowicz added skip-v3-pr Skip validation of presence of a v3 backport PR and removed no-changeset-required labels Sep 2, 2025
@dario-piotrowicz dario-piotrowicz merged commit 5d69df4 into main Sep 2, 2025
46 of 49 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/10361/move-diff-logic branch September 2, 2025 17:32
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 2, 2025
@workers-devprod workers-devprod mentioned this pull request Sep 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundhung edmundhung edmundhung approved these changes

+1 more reviewer

@flakey5 flakey5 flakey5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move remote-diff-check related utilities to a shared location
3 participants
@dario-piotrowicz @edmundhung @flakey5