-
Notifications
You must be signed in to change notification settings - Fork 1k
wrangler: move ratelimit binding to stable #10541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 528ef2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a docs PR, and some tests. Probably a fixture test? I think there's an existing ratelimit one, so that could be extended
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
e8f6fe9
to
6805630
Compare
Thanks @penalosa for the review. I added a fixture test, and linked the docs PR |
Congratulations @qjex, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmfffdhuc0001l804cul9scwn This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
|
||
stable `ratelimit` binding | ||
|
||
[Rate Limiting in Workers ](https://developers.cloudflare.com/workers/runtime-apis/bindings/rate-limit/) is now generally available, `ratelimit` can be removed from unsafe bindings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space here causes formatting checks to fail locally.
Not sure how that was not caught in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rate Limiting in Workers is now generally available. We can now remove
ratelimit
from unsafe bindings.Old unsafe bindings should continue to work as before for now.