Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix version upload e2e test #10547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

fix version upload e2e test #10547

merged 1 commit into from
Sep 4, 2025

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Sep 3, 2025 •
edited
Loading

Fixes #10478.

Wrangler preview urls now default to disabled and a few wrangler e2e tests should be updated.
need to be updated.

  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: update test
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: v4 only

@edmundhung edmundhung requested a review from a team as a code owner September 3, 2025 20:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 547241c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 3, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 3, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10547

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10547

miniflare

npm i https://pkg.pr.new/miniflare@10547

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10547

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10547

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10547

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10547

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10547

wrangler

npm i https://pkg.pr.new/wrangler@10547

commit: 547241c

@edmundhung edmundhung force-pushed the edmundhung/fix-e2e-tests branch from 453cddc to 547241c Compare September 4, 2025 10:49
@edmundhung edmundhung changed the title chore: update test snapshots fix version upload e2e test Sep 4, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 4, 2025
@edmundhung edmundhung merged commit 653f796 into main Sep 4, 2025
31 of 34 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-e2e-tests branch September 4, 2025 11:59
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 4, 2025
@edmundhung edmundhung mentioned this pull request Sep 8, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees
No one assigned
Labels
no-changeset-required
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundhung @dario-piotrowicz