Adds the --force-subdomain-deploy flag to the wrangler triggers deploy command
#10549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 962f91d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
24c5b94 to
8606513
Compare
vicb
reviewed
Sep 4, 2025
vicb
reviewed
Sep 4, 2025
| routes: Route[], | ||
| deployments: Array<Promise<string[]>> | ||
| deployments: Array<Promise<string[]>>, | ||
| forceSubdomainDeploy: boolean |
There was a problem hiding this comment.
Do we really need to add an arg, given that we pass props.forceSubdomainDeploy and props is already the first arg?
There was a problem hiding this comment.
I feel like it is good to be explicit about forcing here. I want to get rid of props arg eventually.
There was a problem hiding this comment.
Could you please reconsider this for now?
You can still explicitly pass props.forceSubdomainDeploy later at the time you refactor the code.
8606513 to
46b317e
Compare
vicb
reviewed
Sep 4, 2025
--force-subdomain-deploy flag to the wrangler triggers deploy command
46b317e to
82b8bf8
Compare
Wrangler will sometimes skip the API call if the config file matches the remote state. However, we need to be able to force it in some cases.
82b8bf8 to
962f91d
Compare
edmundhung
requested changes
Sep 8, 2025
|
We did some changes in the API that should make this flag less urgent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrangler will sometimes skip the API call if the config file matches the remote state. The flag lets us skip this behavior, and force the subdomain deployment.
Follow up of: #10478
Describe your change...
Adds
--force-subdomain-deployflag towrangler triggers deploy.