-
Notifications
You must be signed in to change notification settings - Fork 987
Pin the vercel
and next
dependencies to their latest supported for C3 next-on-pages applications
#10554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 583db8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
b38156a
to
544c147
Compare
Closing since maybe we might just as well skip this step and remove the next-on-pages entry instead |
…r C3 next-on-pages applications
544c147
to
583db8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
As of today C3 e2e (npm/linux) are broken and I believe this would solve that and allow merging PRs top branch.
IMO we should merge this for now and keep discussing what we want for c3/next-no-pages
We've deprecated next-on-pages in cloudflare/next-on-pages#986 and pinned the
vercel
andnext
dependencies to their current latest stable releasesAs a result we also need to update C3 not to use any newer version of
vercel
andnext
, which is what this PR is doingAdditionally there's the question whether we should then remove next-on-pages as a C3 option, that will be discussed with the team and addressed separately