Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

dario-piotrowicz
Copy link
Member

We've deprecated next-on-pages in cloudflare/next-on-pages#986 and pinned the vercel and next dependencies to their current latest stable releases

As a result we also need to update C3 not to use any newer version of vercel and next, which is what this PR is doing

Additionally there's the question whether we should then remove next-on-pages as a C3 option, that will be discussed with the team and addressed separately


  • Tests
    • Tests included
    • Tests not necessary because: this functionality is already all tested
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not something needing documentation
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a wrangler feature

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner September 4, 2025 11:21
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 583db8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 4, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10554

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10554

miniflare

npm i https://pkg.pr.new/miniflare@10554

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10554

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10554

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10554

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10554

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10554

wrangler

npm i https://pkg.pr.new/wrangler@10554

commit: 583db8d

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 4, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/next-on-pages-pin-vercel-next branch from b38156a to 544c147 Compare September 4, 2025 12:13
@dario-piotrowicz
Copy link
Member Author

Closing since maybe we might just as well skip this step and remove the next-on-pages entry instead

@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 4, 2025
@dario-piotrowicz dario-piotrowicz deleted the dario/next-on-pages-pin-vercel-next branch September 4, 2025 13:45
@dario-piotrowicz dario-piotrowicz restored the dario/next-on-pages-pin-vercel-next branch September 8, 2025 08:51
@github-project-automation github-project-automation bot moved this from Done to Untriaged in workers-sdk Sep 8, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/next-on-pages-pin-vercel-next branch from 544c147 to 583db8d Compare September 8, 2025 08:56
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As of today C3 e2e (npm/linux) are broken and I believe this would solve that and allow merging PRs top branch.

IMO we should merge this for now and keep discussing what we want for c3/next-no-pages

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 8, 2025
@dario-piotrowicz dario-piotrowicz merged commit 75d737d into main Sep 8, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 8, 2025
@dario-piotrowicz dario-piotrowicz deleted the dario/next-on-pages-pin-vercel-next branch September 8, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants