support ctx.exports in vitest-pool-workers
#11533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0dc5ba5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b6b4f85 to
a09f165
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
3aba7ce to
11eaa14
Compare
ctx.exports in vitest-pool-workers
11eaa14 to
8d0c798
Compare
4 tasks
penalosa
reviewed
Dec 10, 2025
| ): exports is Cloudflare.Exports { | ||
| return ( | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| (globalThis as any).Cloudflare?.compatibilityFlags.enable_ctx_exports && |
Contributor
There was a problem hiding this comment.
Is this not in workers-types? Should we add it?
Contributor
Author
There was a problem hiding this comment.
Apparently it is "internal"? It's not in our docs.
The only place I could find it being used was in the unenv preset code.
| @@ -1,4 +1,5 @@ | |||
| import assert from "node:assert"; | |||
| import { exports } from "cloudflare:workers"; | |||
Contributor
Author
There was a problem hiding this comment.
It's used on line 64 to add the exports onto the user generated ctx object.
cd1c745 to
b115efe
Compare
penalosa
approved these changes
Dec 11, 2025
jamesopstad
approved these changes
Dec 11, 2025
Contributor
jamesopstad
left a comment
There was a problem hiding this comment.
Very nice, @petebacondarwin! Great that you've managed to apply these changes so cleanly.
… will never teardown and always times out
…OBJECT__` in order to reduce chance of collision with user code. This is the approach used in the Vite plugin and reduces the complexity of our code since we can stop "prefixing" user exports.
b115efe to
0dc5ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to access
ctx.exportsproperties for themain(SELF) worker.Due to the dynamic nature of Vitest the integration relies upon guessing what the exports of the
mainWorker are by statically analyzing the Worker source using esbuild. In cases where it is not possible to infer the exports (for example, a wildcard re-export of a virtual module) it is possible to declare these in the vitest-pool-workers config via theadditionalExportssetting.A picture of a cute animal (not mandatory, but encouraged)