V3 Backport: fix: Automatically convert TOML Date values in vars to strings
#11652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 62cc34e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
1ae6c76 to
4d1914d
Compare
TOML parses unquoted date values like DATE = 2024-01-01 as Date objects. Previously this caused a confusing error from Miniflare. Now wrangler automatically converts Date values to ISO date strings (YYYY-MM-DD format) and shows a warning suggesting to wrap the value in quotes. Co-authored-by: Dario Piotrowicz <[email protected]>
4d1914d to
62cc34e
Compare
vars to strings
Member
Author
|
The original PR hasn't been merged and I don't think it's unlikely to be merged + released in 2025, so probably this v3 backport PR is not necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport for #11651