Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

hippo-an
Copy link
Member

@hippo-an hippo-an commented Sep 15, 2025

제목

chore(tracing): 클라이언트와 서버에 span kind 설정


Category

  • 신규 기능 (New feature)
  • 버그 수정 (Bug fix)
  • 개선 (Improvement)
  • 리팩터 (Refactor)
  • 기타 (etc)

Description

  • SpaceConnector.dispatch: CLIENT span 으로 래핑 (외부 요청 표현)
  • transaction 데코레이터: SERVER span 설정 (내부 요청 표현)

해당 변경으로 트레이스의 정확성과 관찰성을 개선합니다.


Known issue

  • 현재 span kind 는 SpaceConnector(client)transaction(server) 데코레이터에만 적용되었기 때문에, 이 구조를 따르지 않는 트레이스의 경우 추적이 어려울 수 있습니다.
  • console-api-v2 등을 통해서 호출되지 않고 내부적으로 호출되는 호출 사항에 대한 trace 는 명확히 trace 하기 어려울 수 있습니다.

Copy link

⚠️ @hippo-an the signed-off-by was not found in the following 1 commits:

  • c1b5d3d: choretracing): set span kind for client and server

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
Copy link

⚠️ @hippo-an the signed-off-by was not found in the following 1 commits:

  • c1b5d3d: choretracing): set span kind for client and server

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

- SpaceConnector.dispatch: wrap in CLIENT span (outgoing request)
- transaction decorator: set span kind to SERVER (incoming request)

Improves trace accuracy and observability.

Limitations:
- Since span kind is added only to SpaceConnector and the transaction decorator,
  traces that do not follow this structure may be harder to track.

Signed-off-by: hippo-an <[email protected]>
@hippo-an hippo-an force-pushed the add-span-kind-for-tracing branch from c1b5d3d to c079f84 Compare September 15, 2025 06:37
@hippo-an hippo-an merged commit 3eb3f76 into master Sep 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant