Add yarn serve to use as a local dev environment #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-tolosa
commented
Aug 20, 2020
| @@ -2,7 +2,7 @@ const nodeExternals = require("webpack-node-externals"); | |||
|
|
|||
| module.exports = { | |||
| configureWebpack: config => { | |||
| if (process.env.STYLEGUIDE) { | |||
| if (process.env.INTERNAL_DEPS) { | |||
There was a problem hiding this comment.
In VueJS, when building a library we externalize all of the node modules, as they're brought in as dependencies.
When developing locally, we want all INTERNAL_DEPS to be bundled, so we skip the nodeExternals() plugin.
This repurposes an old flag of the STYLEGUIDE which is no longer in use, but did the same thing
strausr
approved these changes
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
This change adds a local dev environment to the developer working on this project.
run
yarn serveto start a local dev environment based off of./playgorund/main.jsWhat does this PR address?
Are tests included?
Reviewer, Please Note:
This is PR has does not affect end-developers but adds functionality when maintaining and adding features to this project