Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add poc object transformation support #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add poc object transformation support #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions __TESTS__/unit/actions/Delivery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {Dpr} from "../../../src/qualifiers/dpr";
import {Delivery} from "../../../src/actions/delivery";
import {createNewImage} from "../../TestUtils/createCloudinaryImage";
import {Progressive} from "../../../src/qualifiers/progressive";
import {CloudinaryImage} from "../../../src";


const {format} = Delivery;
Expand Down Expand Up @@ -348,4 +349,30 @@ describe('Tests for Transformation Action -- Delivery', () => {

expect(url).toContain('f_jpg');
});

it('Test addPOCTransformation', () => {
// f_jpg,fl_progressive
const url = new CloudinaryImage('sample', {cloudName: 'demo'}).addPOCTransformation({

transformation: [
{
if: "w_lt_200",
crop: "fill",
height: 120,
width: 80
},
{
if: "w_gt_400",
crop: "fit",
width: 150,
height: 150
},
{
effect: "sepia"
}
]
}).toURL();

console.log(url);
});
});
8 changes: 8 additions & 0 deletions src/assets/CloudinaryTransformable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import { IAdjustAction } from "../actions/adjust.js";
import { ITrackedPropertiesThroughAnalytics } from "../sdkAnalytics/interfaces/ITrackedPropertiesThroughAnalytics.js";
import { AnimatedAction } from "../actions/animated.js";
import { DeliveryFormatAction } from "@cloudinary/transformation-builder-sdk/actions/delivery/DeliveryFormatAction";
import {generateTransformationString} from "../backwards/generateTransformationString.js";
import {cloneDeep} from "../internal/utils/cloneDeep.js";

/**
* @desc Cloudinary Transformable interface, extended by any class that needs a Transformation Interface
Expand Down Expand Up @@ -274,6 +276,12 @@ class CloudinaryTransformable extends CloudinaryFile {
return this;
}

addPOCTransformation(transformationOptions: any) {
const transformation = generateTransformationString(cloneDeep(transformationOptions)).replace(/([^:])\/\//g, '$1/');
this.transformation.addTransformation(transformation);
return this;
}

toURL(overwriteOptions: { trackedAnalytics?: Partial<ITrackedPropertiesThroughAnalytics> } = {}): string {
return this.createCloudinaryURL(this.transformation, overwriteOptions?.trackedAnalytics);
}
Expand Down