Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: summary file crashes #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 29, 2023
Merged

fix: summary file crashes #305

merged 2 commits into from
Dec 29, 2023

Conversation

dudymas
Copy link
Contributor

@dudymas dudymas commented Dec 28, 2023

what

  • fix(action): look for descriptions before loading them
  • fix(action/file_name): replace all instances of slash

why

  • If a component has multiple slashes in its name, it won't be found
  • if a file isn't found, the reconcile workflow exits immediately instead of
    skipping

@dudymas dudymas requested review from a team as code owners December 28, 2023 13:52
@dudymas dudymas requested review from Gowiem and nitrocode and removed request for a team December 28, 2023 13:52
@dudymas dudymas merged commit 6f8486b into main Dec 29, 2023
@goruha goruha deleted the fix/action/safer-description-handling branch January 31, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudymas @Benbentwo