-
Notifications
You must be signed in to change notification settings - Fork 103
[cloudprober] Add support for reading files from S3 and GCS. #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would be awesome to get this merged! Without checking if this is already done: would be great if the code saved a snapshot of the most recently retrieved content for the config and targets, so that if the backend should be down, or someone uploaded a bad config, the checks still keep working. Also: does this watch for changes and automatically reapplies, like with local files? |
- File based targets - TLS certificate files - OAuth token files - Cloudprober config itself.
Note about this change: It will increase convenience but it will make cloudprober run dependent on external configs. For the most part it's okay -- it will only make debugging a bit harder as you'll have to find the external file content when cloudprober started running. Maybe, as @theduke suggested above, we can cache file contents locally, which will be useful in two cases: a. to debug. I'll consider hashing this out and implementing it in a different pull request / issue. |
* This applies to all kinds of file resources: - File based targets - TLS certificate files - OAuth token files - Cloudprober config itself.
…er#396 as path.join converts double slash into single slash
#396 broke accessing Google Storage as path.join converts any double slash into a single slash.
…ober#396) * This applies to all kinds of file resources: - File based targets - TLS certificate files - OAuth token files - Cloudprober config itself.
cloudprober#396 broke accessing Google Storage as path.join converts any double slash into a single slash.
This applies to all kinds of file resources: