feat: Add method to return token type #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst the token itself now contains the token type, it is useful to be able to determine the type of tokens the token client will return without fetching a token first. An example user of this functionality will be the usage client, which needs to determine if an API call is needed to fetch the team name when the authentication is using an API key. Refs: cloudquery/cloudquery-issues#893
erezrokah
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Unrelated to this PR but I would expect us to know the token type based on the token format, not the env variable (similar to https://github.blog/2021-04-05-behind-githubs-new-authentication-token-formats/#identifiable-prefixes)
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
🤖 I have created a release *beep* *boop* --- ## [1.6.0](v1.5.1...v1.6.0) (2023-11-16) ### Features * Add method to return token type ([#75](#75)) ([e07af9f](e07af9f)) ### Bug Fixes * Generate CloudQuery Go API Client from `spec.json` ([#73](#73)) ([db26b9c](db26b9c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst the token itself now contains the token type, it is useful to be able to determine the type of tokens the token client will return without fetching a token first. An example user of this functionality will be the usage client, which needs to determine if an API call is needed to fetch the team name when the authentication is using an API key.
Refs: https://github.com/cloudquery/cloudquery-issues/issues/893