fix: Retrieve team for api key #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f3edab to
3a57e6e
Compare
⏱️ Benchmark results
|
hermanschaaf
approved these changes
Nov 16, 2023
disq
reviewed
Nov 16, 2023
| } | ||
| return teamName, nil | ||
| case auth.APIKey: | ||
| resp, err := u.apiClient.ListTeamsWithResponse(context.Background(), &cqapi.ListTeamsParams{}) |
There was a problem hiding this comment.
The use of context.Background() isn't very nice here, but then it's in a constructor (NewUsageClient) so the constructor would have to get a ctx otherwise.
There was a problem hiding this comment.
Agreed, but considered it better than changing the constructor in this case.
disq
approved these changes
Nov 16, 2023
Co-authored-by: Herman Schaaf <[email protected]>
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
🤖 I have created a release *beep* *boop* --- ## [4.18.3](v4.18.2...v4.18.3) (2023-11-17) ### Bug Fixes * Retrieve team for api key ([#1372](#1372)) ([940d87f](940d87f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retreive the team associated with an API key to allow usage tracking against a team name
fixes: https://github.com/cloudquery/cloudquery-issues/issues/893