Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Batching for mixedbatchwriter #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: Batching for mixedbatchwriter #1374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d70ad99
Update mixedbatchwriter.go
bbernays Nov 16, 2023
deaa71f
Update mixedbatchwriter.go
bbernays Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion writers/mixedbatchwriter/mixedbatchwriter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func (w *MixedBatchWriter) Write(ctx context.Context, msgChan <-chan message.Wri
batch: make([]*message.WriteInsert, 0, w.batchSize),
writeFunc: w.client.InsertBatch,
maxBatchSizeBytes: int64(w.batchSizeBytes),
logger: w.logger,
}
deleteStale := &batchManager[message.WriteDeleteStales, *message.WriteDeleteStale]{
batch: make([]*message.WriteDeleteStale, 0, w.batchSize),
Expand Down Expand Up @@ -201,6 +202,7 @@ type insertBatchManager struct {
writeFunc func(ctx context.Context, messages message.WriteInserts) error
curBatchSizeBytes int64
maxBatchSizeBytes int64
logger zerolog.Logger
}

func (m *insertBatchManager) append(ctx context.Context, msg *message.WriteInsert) error {
Expand All @@ -218,11 +220,16 @@ func (m *insertBatchManager) flush(ctx context.Context) error {
if len(m.batch) == 0 {
return nil
}

start := time.Now()
batchSize := len(m.batch)
err := m.writeFunc(ctx, m.batch)
if err != nil {
m.logger.Err(err).Int("len", batchSize).Dur("duration", time.Since(start)).Msg("failed to write batch")
return err
}
m.logger.Debug().Int("len", batchSize).Dur("duration", time.Since(start)).Msg("batch written successfully")

m.batch = m.batch[:0]
m.curBatchSizeBytes = 0
return nil
}