feat: Show plugin version in plugin server logs #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
Apr 21, 2025
| } | ||
| } | ||
|
|
||
| func (p *Plugin) PackageAndVersion() string { |
There was a problem hiding this comment.
I didn't want to do a Stringer without any input, but not opposed to it.
disq
commented
Apr 21, 2025
| }() | ||
|
|
||
| logger.Info().Str("address", listener.Addr().String()).Msg("Plugin server listening") | ||
| logger.Info().Str("address", listener.Addr().String()).Str("plugin", s.plugin.PackageAndVersion()).Msg("Plugin server listening") |
There was a problem hiding this comment.
Old line was:
{"address":"/tmp/cq-....sock","message":"Plugin server listening","module":"aws-source"}
erezrokah
approved these changes
Apr 21, 2025
savme
approved these changes
Apr 22, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
🤖 I have created a release *beep* *boop* --- ## [4.79.0](v4.78.0...v4.79.0) (2025-04-28) ### Features * Add transformer to update table description with its table options ([#2128](#2128)) ([2387b57](2387b57)) * Show plugin version in plugin server logs ([#2124](#2124)) ([be08606](be08606)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.10 ([#2132](#2132)) ([775d537](775d537)) * Prevent deadlock in transformer ([#2130](#2130)) ([a65b101](a65b101)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could make certain things easier to debug.