fix: Pass installation ID from env for usage report #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murarustefaan
approved these changes
May 2, 2025
hermanschaaf
reviewed
May 2, 2025
premium/usage.go
Outdated
| switch tokenType { | ||
| case auth.SyncRunAPIKey, auth.SyncTestConnectionAPIKey: | ||
| case auth.APIKey: | ||
| return os.Getenv("_CQ_INSTALLATION_ID") |
There was a problem hiding this comment.
Why switch on token type at all and not always return os.Getenv("_CQ_INSTALLATION_ID")?
hermanschaaf
approved these changes
May 2, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
May 6, 2025
🤖 I have created a release *beep* *boop* --- ## [4.79.1](v4.79.0...v4.79.1) (2025-05-03) ### Bug Fixes * **deps:** Update golang.org/x/exp digest to 7e4ce0a ([#2135](#2135)) ([efb8813](efb8813)) * **deps:** Update module github.com/grpc-ecosystem/go-grpc-middleware/v2 to v2.3.1 ([#2136](#2136)) ([5534187](5534187)) * **deps:** Update module github.com/rs/zerolog to v1.34.0 ([#2138](#2138)) ([e1bcb05](e1bcb05)) * **deps:** Update module google.golang.org/grpc to v1.72.0 ([#2141](#2141)) ([a0f27a3](a0f27a3)) * Pass installation ID from env for usage report ([#2140](#2140)) ([4d36bfb](4d36bfb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2106
Plugins use regular team API keys for usage reports, not platform-specific local API keys.