Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use GitHub actions for continuous integration (CI) #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2021
Merged

Conversation

SimonFrings
Copy link
Contributor

Bye bye Travis CI, you've served us well.
This code supports running tests on PHP 8.

$ docker run -it --rm -v `pwd`:/data --workdir=/data php:8.0.0 php vendor/bin/phpunit
PHPUnit 9.5.4 by Sebastian Bergmann and contributors.

...............................................................  63 / 105 ( 60%)
..........................................                      105 / 105 (100%)

Time: 00:00.039, Memory: 8.00 MB

OK (105 tests, 282 assertions)

Builds on top of #104 and reactphp/reactphp#442.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this! Only added a few minor remarks below.

Bye bye Travis CI, you've served us well.
@SimonFrings SimonFrings force-pushed the ci branch 4 times, most recently from cdc5c2a to f313a1b Compare May 21, 2021 07:22
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue added this to the v2.5.0 milestone May 23, 2021
@clue clue merged commit dc39f79 into clue:master May 23, 2021
@clue clue mentioned this pull request Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants