cbsd/logs: handle errors when gc logs cache#35
Merged
Merged
Conversation
Signed-off-by: Joao Eduardo Luis <[email protected]>
If there are errors when garbage collecting logs from cache (which there were, removing map items while iterating through the map), these were silently ignored and the task would render the server useless. At least now we ensure we log those errors and don't let the task die. Signed-off-by: Joao Eduardo Luis <[email protected]>
61116e9 to
11a16a2
Compare
UweSchwaeke
previously approved these changes
Mar 2, 2026
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are errors when garbage collecting logs from cache (which there
were, removing map items while iterating through the map), these were
silently ignored and the task would render the server useless.
At least now we ensure we log those errors and don't let the task die.
Signed-off-by: Joao Eduardo Luis <[email protected]>
(note: this patch set contains the logs patch set part of #34 , we should only merge this one after the previous has been merged)