cbsd: address critical issues#45
Merged
Merged
Conversation
Every call to Backend.redis() created a new Redis connection that was never closed. Create the connection pool once in __init__() and return the shared instance, adding a close() method for cleanup. Signed-off-by: Joao Eduardo Luis <[email protected]>
token_decode() and Users.create() logged full PASETO tokens at DEBUG level. If CBS_DEBUG is set, every request leaks credentials to the log. Remove token values from log messages entirely. Signed-off-by: Joao Eduardo Luis <[email protected]>
BuildsTracker.new() manually acquired the lock and released it inside a nested _cleanup() function. If an uncaught exception occurred between acquire and cleanup, the lock was never released, permanently blocking all build operations. Restructure to use 'async with self._lock:' and extract cleanup into _fail_entry(). Signed-off-by: Joao Eduardo Luis <[email protected]>
_update_components() called res.get() synchronously inside an async task, blocking the entire asyncio event loop until the Celery worker responded. Use asyncio.to_thread() to run the blocking call in a separate thread. Signed-off-by: Joao Eduardo Luis <[email protected]>
UweSchwaeke
reviewed
Mar 9, 2026
UweSchwaeke
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch set addresses some critical issues that, although not particularly obvious, may introduce significant operational misbehavior.
Signed-off-by: Joao Eduardo Luis <[email protected]>