Return as-loaded gcode in gcode:load event #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dcb264 to
e063ed6
Compare
75cb584 to
9d31b76
Compare
11 tasks
|
It looks good to me for returning the actual state to the UI. Other than the change made in this PR, what do you think of adding a |
2707fe8 to
06785fc
Compare
06785fc to
eb421d0
Compare
cheton
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging programs, it's confusing for the g-code list view to show a different number of lines than the g-code widget. This comes from the fact that the load routines remove blank lines and add a dwell at the end of the program.
This PR syncs those up by returning the as-loaded gcode in the gcode:load event.