Fix CI issues #4711
Fix CI issues #4711
Conversation
12f9b43 to
c21f99f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4711 +/- ##
==========================================
+ Coverage 67.23% 77.11% +9.88%
==========================================
Files 59 59
Lines 8503 8527 +24
Branches 2067 2071 +4
==========================================
+ Hits 5717 6576 +859
+ Misses 2362 1474 -888
- Partials 424 477 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The icarus v12 build tends to hang so we have it timeout after 5 minutes. It's a common failure you just need to re-run it.
Lmao, so we are testing that it doesn't work? I think something got missed and we didn't realize because it's in the experimental bucket. Not your problem. |
| name: Release | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.number }}-${{ github.event.ref }} |
There was a problem hiding this comment.
Is there a reason to use ${{ github.event.number }}-${{ github.event.ref }} instead of ${{ github.ref }} like the docs mention?
There was a problem hiding this comment.
Not sure. I copied it from Matplotlib.
There was a problem hiding this comment.
It was added in matplotlib/matplotlib#22919 but no comments why this particular version was added. Maybe it was the recommended way then?
There was a problem hiding this comment.
Well if it's still working for them we can leave it and see if there's any weird discrepancies in the future.
|
Looks like there is more fallout from #4682 to be fixed:
|
|
Should I rename them in some way? |
|
If so maybe |
|
If this works, I think everything is handled. (If not, I'll be at it tomorrow.) |
.github/generate-envs.py
Outdated
| What tests belong in what groups: | ||
| - ci: The most recent stable release of a given simulator, all supported versions of Python, and all supported operating systems. Run on all PRs and master pushes. | ||
| - ci-free: The most recent stable release of a given free simulator, all supported versions of Python, and all supported operating systems. Run on all PRs and master pushes. | ||
| - ci-licensed: The most recent stable release of a given licensed simulator, all supported versions of Python, and all supported operating systems. Run on all PRs and master pushes in the cocotb repo, but are skipped in forks. |
There was a problem hiding this comment.
| - ci-licensed: The most recent stable release of a given licensed simulator, all supported versions of Python, and all supported operating systems. Run on all PRs and master pushes in the cocotb repo, but are skipped in forks. | |
| - ci-licensed: The most recent stable release of a given licensed simulator. Run on all PRs and master pushes in the cocotb repo, but are skipped in forks. |
|
Well Questa license server is down. I'll try rerunning the tests in an hour. EDIT: No need, my other PR failed. It's down. |
dbf1127 to
e67f46f
Compare
|
Update with the rewording. Also reverted a search-and-replace change in .pre-commit-config.yml that shouldn't have been there. |
ktbarrett
left a comment
There was a problem hiding this comment.
It's good, but I want to ensure Questa checks work before merging. That may or may not be done any time soon.
|
Questa tests are rerunning now. |
Closes #4708
Closes #4709
Move 3.14-test to experimental.
I realised that we can just run two tests in the same file, so no need to duplicate all the skip-stuff. Also this gives a better dependency chain for the deployment.
Added
cancel-in-progress: trueto stop old test runs after pushing to the same branch again (quite useful for me at least, who tend to push before I think...)Also added so that all the changed workflows executes on pull-requests. Will remove that once it is confirmed that it works by someone with correct bits.
I do not think the failing tests are caused by this PR?