fix: Fix incorrect sorting of self-hosted versions on a select menu DOCS-516 - #1618
Merged
Merged
Conversation
inesgomas
reviewed
Feb 7, 2023
inesgomas
reviewed
Feb 7, 2023
inesgomas
approved these changes
Feb 7, 2023
inesgomas
reviewed
Feb 7, 2023
inesgomas
reviewed
Feb 7, 2023
Co-authored-by: Inês Gomes <[email protected]>
Co-authored-by: Inês Gomes <[email protected]>
nicklem
enabled auto-merge (squash)
February 10, 2023 09:44
nicklem
force-pushed
the
fix/dropdown-menu-sorting-DOCS-516
branch
from
February 10, 2023 09:49
f73aa48 to
4b55f41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ordering logic that sorts self-hosted versions on the version select dropdown breaks for numbers >= 10, causing the well-known and wrong sorting
1, 10, 2, 3, 4, ...❗ Note to reviewers
versions.jsonendpoint returns 404.versions.jsonas test data to populate the dropdown in the preview.👀 Live preview
https://fix-dropdown-menu-sorting-docs-516--docs-codacy.netlify.app/
🚧 To do