Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Avoid potential error DOCS-516 - #1621

Merged
nicklem merged 1 commit into
masterfrom
feat/error-handling-DOCS-516
Feb 10, 2023
Merged

nicklem merged 1 commit into
masterfrom
feat/error-handling-DOCS-516

Conversation

@nicklem

@nicklem nicklem commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

This quick fix avoids a potential error in the SH version sorting code.

The error will likely never happen. This is just an extra safeguard.

@nicklem
nicklem requested a review from a team as a code owner February 10, 2023 10:30
@github-actions
github-actions Bot temporarily deployed to Netlify February 10, 2023 10:30 Inactive
@nicklem

nicklem commented Feb 10, 2023

Copy link
Copy Markdown
Contributor Author

@claudiacarpinteiro I added one extra check to the code. Feel free to approve this one; I'll merge it right after.

@nicklem
nicklem merged commit 38b4f17 into master Feb 10, 2023
@nicklem
nicklem deleted the feat/error-handling-DOCS-516 branch February 10, 2023 11:38
@nicklem nicklem changed the title feat: Avoid potential error feat: Avoid potential error DOCS-516 Feb 13, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
prcr pushed a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants