Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pull] main from tursodatabase:main #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

[pull] main from tursodatabase:main #115

merged 2 commits into from
Jun 26, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 26, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.2)

Can you help keep this open source service alive? 💖 Please sponsor : )

o0Ignition0o and others added 2 commits June 13, 2025 09:42
On macos, cp's `--no-preserve` option does not exist. It is enabled by default, and can be disabled with the explicit `-p` (preserve) flag.
This lead libsql-ffi's build.rs to warn about an illegal option used:

```
  cp: illegal option -- -
  usage: cp [-R [-H | -L | -P]] [-fi | -n] [-aclpSsvXx] source_file target_file
         cp [-R [-H | -L | -P]] [-fi | -n] [-aclpSsvXx] source_file ... target_directory
```

This changeset makes sure the option is only passed in non `macos` target_os.
On macos, cp's `--no-preserve` option does not exist. It is enabled by
default, and can be disabled with the explicit `-p` (preserve) flag.
This lead libsql-ffi's build.rs to warn about an illegal option used:

```
  cp: illegal option -- -
  usage: cp [-R [-H | -L | -P]] [-fi | -n] [-aclpSsvXx] source_file target_file
         cp [-R [-H | -L | -P]] [-fi | -n] [-aclpSsvXx] source_file ... target_directory
```

This changeset makes sure the option is only passed in non `macos`
target_os.

It seems like the build.rs file has had quite a lot of bugfixes over
time, especially the CP function, so feel free to dismiss this PR if
you're not comfortable landing it, as it's just a warning, and if the cp
command does not work it will fallback to `copy_dir_all`.

I'm also lacking context on this library so if I'm missing anything
please let me know!

Thanks
@pull pull bot locked and limited conversation to collaborators Jun 26, 2025
@pull pull bot added the ⤵️ pull label Jun 26, 2025
@pull pull bot merged commit eecb25d into code:main Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants