Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pull] canary from vercel:canary #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2025
Merged

[pull] canary from vercel:canary #136

merged 3 commits into from
May 17, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented May 17, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

timneutkens and others added 3 commits May 17, 2025 09:31
## What?

This PR ensures we first clean the `.next/standalone` folder before
writing into it.

Currently the order is:

1. Write package.json to `.next/standalone/package.json`
1. Delete `.next/standalone`
1. Check `.nft.json` files and write the files listed there to
`.next/standalone`

Which in turn causes the package.json to not exist.

So why does this not fail with webpack? Well, what I found is that the
`_app` `.nft.json` file somehow lists the project root `package.json`
even though it does not use it. This means that after we delete
`.next/standalone` the `package.json` will still end up in the eventual
directory regardless.

It fails with Turbopack because Turbopack correctly does not include the
package.json (as it's not used) and then the `package.json` is missing
at runtime, causing the `server.js` which uses ESM to fail (because the
detection for ESM is still valid regardless of deleting the folder).


New order is:

1. Delete `.next/standalone`
1. Write package.json to `.next/standalone/package.json`
1. Check `.nft.json` files and write the files listed there to
`.next/standalone`
…pe instead of the value for client-boundary warnings (#79193)

Best be reviewed with "Hide whitespace".

### Why?

Since it was matching `ts.isObjectBindingPattern`, which checks only the
destructured props:

![CleanShot 2025-05-14 at 12 17
25@2x](https://github.com/user-attachments/assets/44aaffd2-9276-486e-86ce-acb77d488ab0)

It didn't handle non-destructured:

![CleanShot 2025-05-14 at 12 17
34@2x](https://github.com/user-attachments/assets/23abc130-3e17-4f72-89a2-bc084841f52f)

Therefore, I think it's more natural to target the types, not the props
value, as the cause of this warning is actually the types:

![CleanShot 2025-05-14 at 12 18
00@2x](https://github.com/user-attachments/assets/0a5a64c8-1ac9-4b0f-8fe7-20e78db2acec)

![CleanShot 2025-05-14 at 12 17
53@2x](https://github.com/user-attachments/assets/72008c25-7d7b-46e4-8e2f-e52f01e50b80)

x-ref:
#79144 (comment)

---------

Co-authored-by: Janka Uryga <[email protected]>
@pull pull bot added the ⤵️ pull label May 17, 2025
@pull pull bot merged commit 3ecf087 into code:canary May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants