Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement createUserRepository #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2015
Merged

Implement createUserRepository #51

merged 2 commits into from
Jul 17, 2015

Conversation

shunjikonishi
Copy link
Contributor

Implement createUserRepository method.
The reason why i commented out the test is we don't implement deleteRepository yet.
We can't delete repo programatically.

@sukeshni review me

@shunjikonishi shunjikonishi mentioned this pull request Jul 16, 2015
Open
@sukeshni
Copy link
Contributor

@shunjikonishi
Why is it defined in quotes " private: Boolean = false "
https://github.com/code-check/github-api-scala/blob/create-repo/src/main/scala/codecheck/github/models/Repository.scala#L54
Other than that
LGTM

@givery givery assigned shunjikonishi and unassigned sukeshni Jul 17, 2015
@shunjikonishi
Copy link
Contributor Author

Because private is reserved word of Scala.
Most languages can not use reserved word as a field name or variable name.
However Scala can use it with back quote.

shunjikonishi added a commit that referenced this pull request Jul 17, 2015
@shunjikonishi
Merge pull request #51 from code-check/create-repo
b61df6f 
Implement createUserRepository
@shunjikonishi shunjikonishi merged commit b61df6f into master Jul 17, 2015
@shunjikonishi shunjikonishi deleted the create-repo branch July 17, 2015 06:55
@sukeshni
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shunjikonishi shunjikonishi

Labels
Ship it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shunjikonishi @sukeshni @givery