Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make all diagnostic severities configurable #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Make all diagnostic severities configurable #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9dc560d
Extract all diagnostic severities so that we can make default rulesets.
walterlv Aug 30, 2019
3ce813a
Let all csharp analyzers use the configuration rulesets.
walterlv Aug 30, 2019
e50094f
Let all vb analyzers use the configuration rulesets.
walterlv Aug 30, 2019
9a81baf
Add comments for SeverityConfigurations
walterlv Aug 30, 2019
591e0d1
Fix wrong words.
walterlv Aug 30, 2019
bb68959
Make vb and C# severities different.
walterlv Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class CatchEmptyAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.CatchEmpty],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.CatchEmpty));

Expand Down
2 changes: 1 addition & 1 deletion src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class EmptyCatchBlockAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.EmptyCatchBlock],
isEnabledByDefault: true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.EmptyCatchBlock));
Expand Down
5 changes: 3 additions & 2 deletions src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
using System.Linq;
using System.Collections.Immutable;
using System;
using CodeCracker;

namespace CodeCracker.CSharp.Design
{
Expand All @@ -23,7 +24,7 @@ public class MakeMethodStaticAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.MakeMethodStatic],
true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MakeMethodStatic));
Expand Down
7 changes: 4 additions & 3 deletions src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using CodeCracker.Properties;
using CodeCracker;
using CodeCracker.Properties;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
Expand All @@ -21,7 +22,7 @@ public class NameOfAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.NameOf],
isEnabledByDefault: true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NameOf));
Expand All @@ -30,7 +31,7 @@ public class NameOfAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.NameOf_External],
isEnabledByDefault: false,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NameOf_External));
Expand Down
5 changes: 3 additions & 2 deletions src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.CodeAnalysis;
using CodeCracker;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -21,7 +22,7 @@ public class StaticConstructorExceptionAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.StaticConstructorException],
true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StaticConstructorException));
Expand Down
6 changes: 3 additions & 3 deletions src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.Diagnostics;
using System;
using System.Collections.Generic;
Expand All @@ -8,7 +8,7 @@
using System.Collections.Immutable;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;

using CodeCracker;

namespace CodeCracker.CSharp.Design
{
Expand All @@ -23,7 +23,7 @@ public class SwitchWithoutDefaultAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.SwitchCaseWithoutDefault],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SwitchCaseWithoutDefault));

Expand Down
5 changes: 3 additions & 2 deletions src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.CodeAnalysis;
using CodeCracker;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -23,7 +24,7 @@ public class UseInvokeMethodToFireEventAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.UseInvokeMethodToFireEvent],
true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseInvokeMethodToFireEvent));
Expand Down
7 changes: 4 additions & 3 deletions src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Linq;
using CodeCracker.Properties;
using CodeCracker;

namespace CodeCracker.CSharp.Maintainability
{
Expand All @@ -19,7 +20,7 @@ public sealed class XmlDocumentationAnalyzer : DiagnosticAnalyzer
Title,
Title,
SupportedCategories.Maintainability,
DiagnosticSeverity.Info,
SeverityConfigurations.CurrentCS[DiagnosticId.XmlDocumentation_MissingInCSharp],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.XmlDocumentation_MissingInCSharp));

Expand All @@ -28,7 +29,7 @@ public sealed class XmlDocumentationAnalyzer : DiagnosticAnalyzer
Title,
Title,
SupportedCategories.Maintainability,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.XmlDocumentation_MissingInXml],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.XmlDocumentation_MissingInXml));

Expand Down
5 changes: 3 additions & 2 deletions src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.CodeAnalysis;
using CodeCracker;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -22,7 +23,7 @@ public class EmptyFinalizerAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.EmptyFinalizer],
true,
customTags: WellKnownDiagnosticTags.Unnecessary,
description: Description,
Expand Down
5 changes: 3 additions & 2 deletions src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.CodeAnalysis;
using CodeCracker;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -20,7 +21,7 @@ public class MakeLocalVariableConstWhenItIsPossibleAnalyzer :
Title,
MessageFormat,
Category,
DiagnosticSeverity.Info,
SeverityConfigurations.CurrentCS[DiagnosticId.MakeLocalVariableConstWhenItIsPossible],
isEnabledByDefault: true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MakeLocalVariableConstWhenItIsPossible));
Expand Down
4 changes: 2 additions & 2 deletions src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand Down Expand Up @@ -41,7 +41,7 @@ public class RemoveWhereWhenItIsPossibleAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.RemoveWhereWhenItIsPossible],
isEnabledByDefault: true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveWhereWhenItIsPossible));
Expand Down
4 changes: 2 additions & 2 deletions src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.Diagnostics;
using System;
using System.Collections.Immutable;
Expand All @@ -19,7 +19,7 @@ public class SealedAttributeAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.SealedAttribute],
true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SealedAttribute));
Expand Down
3 changes: 2 additions & 1 deletion src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using CodeCracker;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
Expand All @@ -21,7 +22,7 @@ public class StringBuilderInLoopAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Warning,
SeverityConfigurations.CurrentCS[DiagnosticId.StringBuilderInLoop],
isEnabledByDefault: true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringBuilderInLoop));
Expand Down
4 changes: 2 additions & 2 deletions src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -20,7 +20,7 @@ public class UseStaticRegexIsMatchAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Info,
SeverityConfigurations.CurrentCS[DiagnosticId.UseStaticRegexIsMatch],
true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseStaticRegexIsMatch));
Expand Down
4 changes: 2 additions & 2 deletions src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Collections.Immutable;
using System.Collections.Immutable;
using System.Linq;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
Expand All @@ -19,7 +19,7 @@ public class AddBracesToSwitchSectionsAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.AddBracesToSwitchSections],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AddBracesToSwitchSections));

Expand Down
4 changes: 2 additions & 2 deletions src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -18,7 +18,7 @@ public class AllowMembersOrderingAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.AllowMembersOrdering],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AllowMembersOrdering));

Expand Down
4 changes: 2 additions & 2 deletions src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ public class ChangeAnyToAllAnalyzer : DiagnosticAnalyzer
TitleAny,
MessageAny,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.ChangeAnyToAll],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ChangeAnyToAll));
internal static readonly DiagnosticDescriptor RuleAll = new DiagnosticDescriptor(
DiagnosticId.ChangeAllToAny.ToDiagnosticId(),
TitleAll,
MessageAll,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.ChangeAllToAny],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ChangeAllToAny));

Expand Down
3 changes: 2 additions & 1 deletion src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using CodeCracker;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
Expand All @@ -20,7 +21,7 @@ public class ComputeExpressionAnalyzer : DiagnosticAnalyzer
Title,
Message,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.ComputeExpression],
isEnabledByDefault: true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ComputeExpression));
Expand Down
5 changes: 3 additions & 2 deletions src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using CodeCracker.Properties;
using CodeCracker;
using CodeCracker.Properties;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
Expand All @@ -22,7 +23,7 @@ public class IntroduceFieldFromConstructorAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.IntroduceFieldFromConstructor],
isEnabledByDefault: true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IntroduceFieldFromConstructor));
Expand Down
4 changes: 2 additions & 2 deletions src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -18,7 +18,7 @@ public class InvertForAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.InvertFor],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.InvertFor));

Expand Down
4 changes: 2 additions & 2 deletions src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -18,7 +18,7 @@ public class MergeNestedIfAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.MergeNestedIf],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MergeNestedIf));

Expand Down
2 changes: 1 addition & 1 deletion src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class NumericLiteralAnalyzer : DiagnosticAnalyzer
Title,
Message,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.NumericLiteral],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NumericLiteral));

Expand Down
5 changes: 3 additions & 2 deletions src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.CodeAnalysis;
using CodeCracker;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
Expand All @@ -19,7 +20,7 @@ public class ParameterRefactoryAnalyzer : DiagnosticAnalyzer
Title,
MessageFormat,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.ParameterRefactory],
isEnabledByDefault: true,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ParameterRefactory));

Expand Down
5 changes: 3 additions & 2 deletions src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using CodeCracker.Properties;
using CodeCracker;
using CodeCracker.Properties;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
Expand Down Expand Up @@ -33,7 +34,7 @@ public sealed class PropertyChangedEventArgsUnnecessaryAllocationAnalyzer : Diag
Title,
MessageFormat,
Category,
DiagnosticSeverity.Hidden,
SeverityConfigurations.CurrentCS[DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation],
isEnabledByDefault: true,
description: Description,
helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation));
Expand Down
Loading