Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch to PackageReference #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

Switch to PackageReference #997

merged 1 commit into from
Oct 23, 2018

Conversation

sharwell
Copy link
Contributor

No description provided.

@sharwell sharwell force-pushed the package-reference branch 2 times, most recently from 1287c3f to c3d4735 Compare September 10, 2018 01:04
@carloscds
Copy link
Contributor

@sharwell Hi, can you check errors on build ?

@sharwell
Copy link
Contributor Author

@carloscds Yep, I've made some progress but haven't reached the end yet

@sharwell sharwell force-pushed the package-reference branch 2 times, most recently from 16911ba to 71142be Compare September 10, 2018 02:10
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 91.618% when pulling ef89297 on sharwell:package-reference into 5e164b0 on code-cracker:master.

@sharwell
Copy link
Contributor Author

Looks like 7th try did it 😆

sharwell
sharwell commented Sep 10, 2018
View reviewed changes
src/CSharp/CodeCracker/CodeCracker.csproj
@@ -34,6 +35,15 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<PropertyGroup>
<RuntimeIdentifiers>win</RuntimeIdentifiers>
<CopyNuGetImplementations>true</CopyNuGetImplementations>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This pair of properties is required for the non-CPS project system to copy dependencies of PCL projects to the output directory, which is required for ILMerge to work. This block would not be required if/when the code switches to CPS based projects and .NET Standard, where CopyLocalLockFileAssemblies can be used instead.

@sharwell sharwell mentioned this pull request Sep 10, 2018
Merged
@carloscds carloscds merged commit ef89297 into code-cracker:master Oct 23, 2018
@sharwell sharwell deleted the package-reference branch November 27, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @carloscds @coveralls