Convert tests to Microsoft.CodeAnalysis.Testing #999
Conversation
| @@ -17,7 +18,7 @@ namespace ConsoleApplication1 | |||
| { | |||
| class TypeName | |||
| { | |||
| public async Task Foo() | |||
| public async {|CS0246:Task|} {|CS0161:{|CS1983:Foo|}|}() | |||
There was a problem hiding this comment.
📝 These compiler errors are due to a missing import of System.Threading.Tasks. The current form is a direct translation of the previous test to the new framework. If the compiler errors were not intended, let me know and I can update the test.
| { | ||
| if (x == 1) | ||
| throw; | ||
| else | ||
| return; | ||
| } | ||
| }|] |
There was a problem hiding this comment.
💡 The new test library revealed that the span of this diagnostic covers the entire catch clause. If this wasn't specifically intended, consider filing a bug to only report the warning on the catch token.
| @@ -44,7 +45,7 @@ namespace ConsoleApplication1 | |||
| { | |||
| class TypeName | |||
| { | |||
| public async Task Foo() | |||
| public async {|CS0246:Task|} {|CS0161:{|CS1983:Foo|}|}() | |||
There was a problem hiding this comment.
📝 These compiler errors are due to a missing import of System.Threading.Tasks. The current form is a direct translation of the previous test to the new framework. If the compiler errors were not intended, let me know and I can update the test.
3d26d69 to
415d5e9
Compare
| @@ -36,7 +38,7 @@ namespace ConsoleApplication1 | |||
| { | |||
| class TypeName | |||
| { | |||
| public async Task Foo() | |||
| public async {|CS0246:Task|} {|CS0161:{|CS1983:Foo|}|}() | |||
There was a problem hiding this comment.
📝 Compiler errors due to missing import for System.Threading.Tasks
| @@ -137,16 +149,16 @@ namespace ConsoleApplication1 | |||
| { | |||
| class TypeName | |||
| { | |||
| public async Task Foo() | |||
| public async {|CS0246:Task|} {|CS0161:{|CS1983:Foo|}|}() | |||
There was a problem hiding this comment.
📝 Compiler errors due to missing import for System.Threading.Tasks
| @@ -162,7 +174,7 @@ namespace ConsoleApplication1 | |||
| { | |||
| class TypeName | |||
| { | |||
| public async Task Foo() | |||
| public async {|CS0246:Task|} {|CS0161:{|CS1983:Foo|}|}() | |||
There was a problem hiding this comment.
📝 Compiler errors due to missing import for System.Threading.Tasks
|
@carloscds If you have any trouble using this library (a near certainty at times), please do not hesitate to contact me on Gitter and/or file a bug report on dotnet/roslyn-sdk. |
|
@sharwell Thanks! |
🚧 This is a work in progress as part of validating the new library works well with different analyzer projects.
Blocked on #998 (and the diff will get much smaller after that one is merged).