Feat/add electron browser to playwright #2834
Conversation
There was a problem hiding this comment.
Hey, this PR is awesome!
But it needs to be documented so everyone knew how to test Electron apps!
Could you add a section about Electron testing to a guide here https://github.com/codeceptjs/CodeceptJS/blob/3.x/docs/playwright.md
And list electron as an option here:
https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/Playwright.js#L61
Thanks!
lib/helper/Playwright.js
Outdated
| const popupStore = new Popup(); | ||
| const consoleLogStore = new Console(); | ||
| const availableBrowsers = ['chromium', 'webkit', 'firefox']; | ||
| const availableBrowsers = ['chromium', 'webkit', 'firefox', '_electron']; |
There was a problem hiding this comment.
| const availableBrowsers = ['chromium', 'webkit', 'firefox', '_electron']; | |
| const availableBrowsers = ['chromium', 'webkit', 'firefox', 'electron']; |
Maybe let's just call it electron? Why not?
There was a problem hiding this comment.
Hey,
sorry I had a few busy weeks and it took me a while to finish this PR. Please have a look again, I have renamed the browser from _electron to electron and added some documentation as well as some other needed changes.
There was a problem hiding this comment.
Thanks @cbayer97
This was a very hard week (month) for me so I just got here to look at updated PR. Everything looks good! 👍
e703ae0 to
2c65fe2
Compare
Motivation/Description of the PR
playwright.chromium.launch(...)vs.playwright._electron.launch(...)). I'd love to see this additional "browser" being added to the CodeceptJs Playwright helper and would be willing to do that if you are in favor of the idea.Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)