-
-
Notifications
You must be signed in to change notification settings - Fork 750
Increase ~ considerable speed in Appium and support ~ with aria-label in WebDriverIO #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hLocator() in WebDriverIO.js
This change breaks build for Appium. Please check https://semaphoreci.com/codeception/codeceptjs/branches/pull-request-728/builds/1 for details |
….g. waitForElement()
Looks good to me. Area-label should be added to documentation.
@flyskywhy could you bring the small example with React native - react-web with area-label ? |
… Also it's an example needed by codeceptjs/CodeceptJS#728
A small sample component could be:
A full example of app and test write once run on Android, iOS and Web is my forked and modified noder-react-native , I just test it in Android and Web successfully with the
then the tab on the homepage can be clicked by e.g. After you accept the PR and publish a new version, then I can remove ps: that's aria-label not area-label 😝 |
Thanks! |
… Also it's an example needed by codeceptjs/CodeceptJS#728
xpathLocator()
in WebDriverIO.js take too long time, and locator ~ does not need it, so be the 1st commit.JS code write once run on Android, iOS and Web by react-native and react-web, now test case with locator ~ write once run on them too, so be the 1st and 2nd commit.