Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Circle ci: dockerized tests #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2017
Merged

Circle ci: dockerized tests #796

merged 2 commits into from
Nov 30, 2017

Conversation

jploskonka
Copy link
Contributor

@jploskonka jploskonka commented Nov 27, 2017 •
edited
Loading

Why?

#747 introduced dockerized test environment for easier usage in development. However TravisCI still use non-dockerized way of running it. Also Docker is fun and I really want to have Appium tests working in emulator :D

Differences with TravisCI

  • builds against 3 node versions instead of 2 (6.9.5, 8.9.1 and 9.2.0)
  • Running acceptance tests (we skip them on travis)
  • Because of building docker containers and my lack of experience with optimizing it build takes a bit longer than TravisCI (~14min vs ~10min). However for one more node version and additional acceptance specs I'd say it's not bad for first version :)

TODO

  • - move shell scripts to well... shell scripts instead of keeping them in yml :P
  • - simplify config.yml
  • - Fix 2 examples failing on CircleCI

@DavertMik I have two WebDriverIO exmaples failing on CircleCI unfortunately, I wasn't able to reproduce it locally and it also used to work OK there - I have no idea yet what is going on here :D If you have any suggestion what may be wrong please let me know, maybe you saw something like this before :)

@jploskonka jploskonka force-pushed the circle-ci-dockerized-tests branch 2 times, most recently from fa9badb to 9982378 Compare November 28, 2017 13:32
@jploskonka jploskonka force-pushed the circle-ci-dockerized-tests branch from 9982378 to 6f42a79 Compare November 28, 2017 13:38
DavertMik
DavertMik approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We can keep Travis CI for fast feedback and use Circle for heavy tests.
And what about Appium? You see the way to make it work in emulator? ;)

@jploskonka
Copy link
Contributor Author

I will have one more shot at those failing scenarios before merging this week - it's for sure some small mistake ;) Also I cleaned up config, removed my "optimizations" (I way overdid it with circle workflows and custom caching :D) and went down to little bit over 10min build :)

As for Appium I haven't look into that yet but for sure will follow one day, I have pretty limited time for codecept unfortunately right now.

@DavertMik
Copy link
Contributor

I have pretty limited time for codecept unfortunately right now.

Wow. your limited time looks like greater than mine )
Ok, will be waiting for final update then!
Btw, looks like we are going to remove Node 6 support so it can be dropped from versions

@jploskonka jploskonka force-pushed the circle-ci-dockerized-tests branch 2 times, most recently from ed2fc40 to 60f3b70 Compare November 29, 2017 15:18
@jploskonka jploskonka force-pushed the circle-ci-dockerized-tests branch from 60f3b70 to b437dbe Compare November 29, 2017 15:42
@jploskonka
Copy link
Contributor Author

@DavertMik looks ready to merge :D

I'm not sure why travis build wasn't triggered for this one, it passed for my fork: https://travis-ci.org/jploskonka/CodeceptJS/builds/309036420

Also I had problems with expectError utility, for some unknown to me reason examples with it started failing because expectations were applied against error thrown by it instead of expected. Always good to remove some code ;-)

@DavertMik DavertMik merged commit 563f1a9 into codeceptjs:master Nov 30, 2017
@jploskonka jploskonka deleted the circle-ci-dockerized-tests branch January 4, 2018 16:30
@adrianblynch adrianblynch mentioned this pull request May 13, 2022
Open
@obender obender mentioned this pull request May 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jploskonka @DavertMik