Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix displaying undefined args in output #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2017
Merged

fix displaying undefined args in output #798

merged 1 commit into from
Dec 2, 2017

Conversation

APshenkin
Copy link
Collaborator

undefined args in test break it.

example:

Scenario.only('test', (I) => {
let b;
I.assertEqual(b, 'undefined');
});

expected:

@Test --
 test
 • I assert equal undefined, "undefined"
 ✖ FAILED in 7ms


-- FAILURES:

  1) @Test: test:
     undefined == 'undefined'
  
  Scenario Steps:
  
  - I.assertEqual(undefined, "undefined") at Test.Scenario (tests/test.js:12:5)

actual:

@Test --
 test
 ✖ FAILED in 1ms


-- FAILURES:

  1) @Test: test:
     Cannot read property 'toString' of undefined

This PR will fix the issue

@APshenkin APshenkin requested a review from DavertMik December 1, 2017 09:02
@DavertMik
Copy link
Contributor

Thanks!

@DavertMik DavertMik merged commit 72c8ef2 into master Dec 2, 2017
@DavertMik DavertMik deleted the undefined-arg-fix branch December 2, 2017 08:56
@adrianblynch adrianblynch mentioned this pull request May 13, 2022
Open
@obender obender mentioned this pull request May 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@APshenkin @DavertMik