Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace default xml rules with rules name #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2017
Merged

Replace default xml rules with rules name #20

merged 1 commit into from
Sep 26, 2017

Conversation

filipesperandio
Copy link
Contributor

Those are equivalent. We were keeping a ruleset.xml that is a copy of the "java-basic".
Using the name instead prevent us from having to maintain this file on version upgrades.

@codeclimate-hermes codeclimate-hermes requested review from dblandin and removed request for codeclimate-hermes September 26, 2017 11:34
dblandin
dblandin approved these changes Sep 26, 2017
View reviewed changes
Copy link

@dblandin dblandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@filipesperandio filipesperandio merged commit 4283842 into master Sep 26, 2017
@filipesperandio filipesperandio deleted the fe/default_ruleset branch September 26, 2017 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dblandin dblandin dblandin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipesperandio @dblandin @wfleming