Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use minimum_severity when reporting issues #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 19, 2017
Merged

Use minimum_severity when reporting issues #47

merged 4 commits into from
Oct 19, 2017

Conversation

filipesperandio
Copy link
Contributor

Related to #11

@codeclimate-hermes codeclimate-hermes requested review from wilson and removed request for codeclimate-hermes October 19, 2017 19:33
wilson
wilson approved these changes Oct 19, 2017
View reviewed changes
Copy link

@wilson wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The CC extension warns about the use of System.out but it seems fine to me.

@filipesperandio
Copy link
Contributor Author

@wilson Indeed, I may disable this check in another PR.

@filipesperandio filipesperandio merged commit 5bee389 into channel/beta Oct 19, 2017
@filipesperandio filipesperandio deleted the fe/severity branch October 19, 2017 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@wilson wilson wilson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipesperandio @wilson