Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

filipesperandio
Copy link
Contributor

No description provided.

Copy link

@chrishulton chrishulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small comments - LGTM overall. I'm not that familiar with sonar, so it might be worth also requesting review from someone who has been reviewing the sonar-java PRs (they might have some additional feedback).

README.md Outdated
[![Maintainability](https://api.codeclimate.com/v1/badges/2bdcb2e92bbc0efb855b/maintainability)](https://codeclimate.com/github/codeclimate/codeclimate-sonar-php/maintainability)
[![Test Coverage](https://api.codeclimate.com/v1/badges/2bdcb2e92bbc0efb855b/test_coverage)](https://codeclimate.com/github/codeclimate/codeclimate-sonar-php/test_coverage)

`codeclimate-sonar-java` is a Code Climate engine that wraps [Sonarlint](http://www.sonarlint.org) in standalone mode.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be codeclimate-sonar-php right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely!

README.md Outdated
Ignore issues with severity below the minimum:
```
engines:
sonar-java:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment here: this should be sonar-php ?

@filipesperandio filipesperandio merged commit f1963d3 into master Nov 1, 2017
@filipesperandio filipesperandio deleted the init branch November 1, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants