Initial Implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $(IMAGE_NAME) -c 'python setup.py test && codeclimate-test-reporter' | ||
|
|
||
| image: | ||
| docker build --rm -t $(IMAGE_NAME) . |
There was a problem hiding this comment.
Nit: --rm is the default on 1.9+, I think. I don't think we've been putting it on newer repos.
5cd249a to
edcf3af
Compare
|
@codeclimate/review This is ready for another 🔎 ! |
|
|
||
| __author__ = "Code Climate" | ||
| __version__ = open(os.path.join(os.path.dirname(__file__), "VERSION")).read().strip() | ||
| __licence__ = "MIT" |
|
Seems cool to me! If it works for you locally I say |
- Dockerfile for development/testing - requirements.txt file for dependencies - reporter/main.py entrypoint - debug flag for library/python/platform versions - Use pytest for tests
edcf3af to
6b50b02
Compare
Sounds good! I'll work on the docs in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the initial implementation for our python test reporter. The reporter supports Coverage.py, which is a popular Python tool for measuring code coverage. This project has been influenced by the interface of two coveralls reporters which read the a Coverage.py coverage file from the default location of
./.coverage.Coverage.py has a few reporters available. The one that I thought made most sense to use was the XML reporter, so the package is currently generating that report to then read and parse while generating a JSON payload for our API.
@codeclimate/review 🔎
Project structure
CLI
Todo