Add compatibility with PHP 8.1 (getsentry#559)

Jean85 · web-flow · commit 42787b4f8a8f · 2021-10-08T17:42:11.000+02:00
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -18,6 +18,7 @@ jobs:
       fail-fast: false
       matrix:
         php:
+          - '8.1'
           - '8.0'
           - '7.4'
           - '7.3'
diff --git a/tests/End2End/App/Controller/MainController.php b/tests/End2End/App/Controller/MainController.php
@@ -41,7 +41,7 @@ public function exception(): Response
 
     public function fatal(): Response
     {
-        $foo = eval("return new class() implements \Serializable {};");
+        $foo = eval("return new class() implements \JsonSerializable {};");
 
         return new Response('This response should not happen: ' . json_encode($foo));
     }
diff --git a/tests/End2End/End2EndTest.php b/tests/End2End/End2EndTest.php
@@ -151,7 +151,7 @@ public function testGetFatal(): void
             $this->assertStringNotContainsString('not happen', $response->getContent() ?: '');
         } catch (\RuntimeException $exception) {
             $this->assertStringContainsStringIgnoringCase('error', $exception->getMessage());
-            $this->assertStringContainsStringIgnoringCase('contains 2 abstract methods', $exception->getMessage());
+            $this->assertStringContainsStringIgnoringCase('contains 1 abstract method', $exception->getMessage());
             $this->assertStringContainsStringIgnoringCase('MainController.php', $exception->getMessage());
             $this->assertStringContainsStringIgnoringCase('eval()\'d code on line', $exception->getMessage());
         }

-Original file line number
+Diff line change
       fail-fast: false
       matrix:
         php:
 +          - '8.1'
           - '8.0'
           - '7.4'
           - '7.3'
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function exception(): Response`
`41`	`41`
`42`	`42`	`public function fatal(): Response`
`43`	`43`	`{`
`44`		`- $foo = eval("return new class() implements \Serializable {};");`
	`44`	`+ $foo = eval("return new class() implements \JsonSerializable {};");`
`45`	`45`
`46`	`46`	`return new Response('This response should not happen: ' . json_encode($foo));`
`47`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ public function testGetFatal(): void`
`151`	`151`	`$this->assertStringNotContainsString('not happen', $response->getContent() ?: '');`
`152`	`152`	`} catch (\RuntimeException $exception) {`
`153`	`153`	`$this->assertStringContainsStringIgnoringCase('error', $exception->getMessage());`
`154`		`- $this->assertStringContainsStringIgnoringCase('contains 2 abstract methods', $exception->getMessage());`
	`154`	`+ $this->assertStringContainsStringIgnoringCase('contains 1 abstract method', $exception->getMessage());`
`155`	`155`	`$this->assertStringContainsStringIgnoringCase('MainController.php', $exception->getMessage());`
`156`	`156`	`$this->assertStringContainsStringIgnoringCase('eval()\'d code on line', $exception->getMessage());`
`157`	`157`	`}`